Make smbd_lock_socket/smbd_unlock_socket recursive with a ref_count.

Jeremy Allison jra at samba.org
Thu Apr 1 09:28:51 MDT 2010


On Thu, Apr 01, 2010 at 10:30:46AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> 
> > - Log -----------------------------------------------------------------
> > commit 6800fdbb81130b79c2e077e9a7fcbe2d5e0813cb
> > Author: Jeremy Allison <jra at samba.org>
> > Date:   Wed Mar 31 17:40:30 2010 -0700
> > 
> >     Make smbd_lock_socket/smbd_unlock_socket recursive with a ref_count.
> >     
> >     As these always call exit_server, make that part of the function.
> >     Use _internal functions for the echo client.
> >     
> >     Metze please check !
> 
> The changes look ok...

Thanks !

> > Summary of changes:
> >  source3/smbd/globals.h     |   10 ++++-
> >  source3/smbd/process.c     |   78 +++++++++++++++++++++----------------------
> >  source3/smbd/reply.c       |   17 ++-------
> >  source3/smbd/smb2_read.c   |    8 ++++
> >  source3/smbd/smb2_server.c |    2 +-
> >  source3/smbd/smb2_write.c  |    9 +++++
> >  6 files changed, 68 insertions(+), 56 deletions(-)
> 
> But please make use of 'git add -i', 'git diff --cached', 'git commit'
> to select only the related changes into the commit
> and then use 'git show' to see what's in the commit.

Damn. Did not mean to commit the smb2 changes - they're
currently a work in progress to track down iozone
corruption (although they're harmless).

Thanks,

Jeremy.


More information about the samba-technical mailing list