[PATCH][SAMBA4] data_blob_hex_string() output is now lowercase.

Matthias Dieter Wallnöfer mdw at samba.org
Sun Sep 27 02:37:36 MDT 2009


abartlet, for now I applied only the test patch to my personal repo. 
That should be ok?

Matthias

Andrew Bartlett schrieb:
> On Sat, 2009-09-26 at 05:51 -0500, Andrew Kroeger wrote:
>   
>> All:
>>
>> Please find attached a patch that addresses a couple of the test 
>> failures in the Samba4 test suite, due to case sensitivity changes in 
>> generating hex blob strings.
>>
>> Testing via "make test" (with and without commit 
>> b84edabbe9f358031117de2cf78613c704ac600 and the supplied patch) shows 
>> that this patch corrects issues with the expected case of return values 
>> in 2 of the failing Samba4 torture tests.
>>
>> All other test failures in the Samba4 test suite occur regardless of 
>> whether commit b84edabbe9f358031117de2cf78613c704ac600 (or my proposed 
>> patch) has or has not been applied.
>>     
>
> I think the right approach it to change data_blob_hex_string() to
> generate an upper case string, but to have the extended DN code call a
> lowercase version for this specific task, given the specific
> requirement.
>
> Andrew Bartlett
>
>   



More information about the samba-technical mailing list