[Patch] Make samba4 return a correct Supported Encryption

Matthias Dieter Wallnöfer mwallnoefer at yahoo.de
Fri Sep 11 03:07:17 MDT 2009

to be honest, I find my reworked version now very clear. We ask for the attributes where we need them. Sure, we'd have some small speedup (one lookup less) but if you consider the LDB modules  - also they often have more lookups than really needed. More lookups generally means to be more clear in design.
The other point is (like Andrew mentioned) that the design of this call still isn't completed fully yet. There is missing the "dNSDomainName" and "servicePrincipalName" handling (maybe some more checks, also the "samldb" module will be enhanced).
So if you really want this patch in - please repost it after the final design.

--- Andrew Bartlett <abartlet at samba.org> schrieb am Do, 10.9.2009:

Von: Andrew Bartlett <abartlet at samba.org>
Betreff: Re: [Patch] Make samba4 return a correct Supported Encryption
An: "Matthieu Patou" <mat+Informatique.Samba at matws.net>
CC: mdw at samba.org, "samba-technical" <samba-technical at lists.samba.org>
Datum: Donnerstag, 10. September 2009, 23:33

On Thu, 2009-09-10 at 19:58 +0400, Matthieu Patou wrote:
> >
> >> Metze, Andrew,
> >>
> >> Find attached the version that use the IDL (good point because it
> >> allowed me to realize that we should return 0x07 in fact ...) with int32
> >> and a silent cast from samdb_search_int64.
> >>      
> > I just noticed that we already do a samdb_search_string(),
> > which would mean we do 2 ldb searches for the same object.
> > I think we should use only one search, maybe using gendb_search_dn()
> > and ldb_msg_find_attr_as_uint().
> >
> >    
> >> I attached the version with both generated code and not generated code
> >> included in the patch.
> >>      
> > Note: the leading whitespaces in the idl changes...
> >
> > metze
> >
> >    
> Hi Metze, Andrew,
> Find attach a patch that take metze remarks in account.


Your patch looks good, but mdw beat you do modifying the file, so your
patch now conflicts.  Perhaps work with him to sort out the changes?  (I
think he is doing other work on that call).

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.


More information about the samba-technical mailing list