[Patch] Make samba4 return a correct Supported Encryption

Andrew Bartlett abartlet at samba.org
Thu Sep 10 15:33:38 MDT 2009


On Thu, 2009-09-10 at 19:58 +0400, Matthieu Patou wrote:
> >
> >> Metze, Andrew,
> >>
> >> Find attached the version that use the IDL (good point because it
> >> allowed me to realize that we should return 0x07 in fact ...) with int32
> >> and a silent cast from samdb_search_int64.
> >>      
> > I just noticed that we already do a samdb_search_string(),
> > which would mean we do 2 ldb searches for the same object.
> > I think we should use only one search, maybe using gendb_search_dn()
> > and ldb_msg_find_attr_as_uint().
> >
> >    
> >> I attached the version with both generated code and not generated code
> >> included in the patch.
> >>      
> > Note: the leading whitespaces in the idl changes...
> >
> > metze
> >
> >    
> Hi Metze, Andrew,
> Find attach a patch that take metze remarks in account.

Matthieu,

Your patch looks good, but mdw beat you do modifying the file, so your
patch now conflicts.  Perhaps work with him to sort out the changes?  (I
think he is doing other work on that call).

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090911/f539c647/attachment.pgp>


More information about the samba-technical mailing list