[PATCH 1/1] PIDL fix for using external types with wireshark backend

ronnie sahlberg ronniesahlberg at gmail.com
Tue Oct 6 02:50:00 MDT 2009

In a way, I think that pidl is defaulting all unknown types to 4 byte
alignment is a bug.
Maybe it would be better if pidl just aborted with an error  : "dont
know alignment for type foo"

I am referring to this code :
	unless (hasType($e)) {
	    # it must be an external type - all we can do is guess
		# warning($e, "assuming alignment of unknown type '$e' is 4");
	    return 4;

I dont if you rely on this and that unknown types default to 4bytes,
so I cant estimate if or how much it would break if this would become
a die("...")

On Tue, Oct 6, 2009 at 7:17 PM,  <tridge at samba.org> wrote:
>  > Please review this patch to pidl.
> applied, thanks!
> thanks very much for your effort on NDR64 for wireshark. This will
> make my life much easier :-)
> Cheers, Tridge

More information about the samba-technical mailing list