[PATCH 1/1] PIDL fix for using external types with wireshark backend

Stefan (metze) Metzmacher metze at samba.org
Tue Oct 6 03:26:57 MDT 2009

Hi Ronnie,

> I am referring to this code :
> 	unless (hasType($e)) {
> 	    # it must be an external type - all we can do is guess
> 		# warning($e, "assuming alignment of unknown type '$e' is 4");
> 	    return 4;
> 	}
> I dont if you rely on this and that unknown types default to 4bytes,
> so I cant estimate if or how much it would break if this would become
> a die("...")

Yes, it's a bug, but it's not trivial to fix for the samba case.
We need to implement the 'import' statement more correct
and need to make the global %typelist dynamic for each file we
process. Currently pidl is able to compile more than one idl file
at a time (and samba uses this to speed up the compilation),
but the problem is that types are not removed between the compilations
of different files.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091006/1d0e0e14/attachment.pgp>

More information about the samba-technical mailing list