s4/torture: port SMBv1 RAW-LOCK tests to SMBv2

Andrew Bartlett abartlet at samba.org
Thu Nov 26 15:23:31 MST 2009

On Wed, 2009-11-25 at 14:56 -0600, Steven Danneman wrote:
> The branch, master has been updated
>        via  f66612f... s4/torture: port SMBv1 RAW-LOCK tests to SMBv2
>        via  7f14388... s4/libcli: rename previously reserved field in SMB2 LOCK struct
>        via  65a611e... s4/libcli: Initialize client PID for SMB2 connections
>       from  95108f1... s3-registry: fix REG_MULTI_SZ handling in registry_push_value.
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> - Log -----------------------------------------------------------------
> commit f66612f62e43b752cb7461da429efd26d1c47296
> Author: Steven Danneman <steven.danneman at isilon.com>
> Date:   Wed Nov 18 16:35:03 2009 -0800
>     s4/torture: port SMBv1 RAW-LOCK tests to SMBv2

Did you get Samba4's 'make test' to pass after you made these changes?

I'm getting failures that look very much like this work. (maximum
runtime exceeded for smbtorture - terminating)

We must *always* have 'make test' passing in both trees, whenever
torture changes are made.  It is not enough for changes to be 'correct',
the server code it tests should be fixed, or at an absolute last resort,
the tests marked up as knownfail.  In this case, the test hangs, which
must be fixed regardless. 

This troubles me particularly today because I'm trying to make a Samba4
alpha release. 

Please fix or revert. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091127/c6584f13/attachment.pgp>

More information about the samba-technical mailing list