[IPA] Disabling Heimdal service

Endi Sukma Dewata edewata at redhat.com
Tue Nov 24 00:22:42 MST 2009


----- "Andrew Bartlett" <abartlet at samba.org> wrote:

> > The second one copies some additional setup files into the install dir. 

> I'm not sure on this.  I'll push the ldap_backend_start.sh template into
> inline strings in the python code, I think it's too small and silly to
> bother having in a file.

Ok, feel free to remove this part from the patch.

> The copy of the schema is a bit more of a worry to me - where does it
> end up exactly?

cp -r ../examples $SETUPDIR/../..

In this command the $SETUPDIR points to $DESTDIR/share/setup. $DESTDIR
is the installation directory, e.g. /usr/local/samba. So the command will
copy the examples into $DESTDIR becoming $DESTDIR/examples.

The relative location of the setup and examples directories in the 
installation directory will be the same as that in the source directory.
See also provisionbackend.py line 569:

self.samba3_schema = self.setup_path("../../examples/LDAP/samba.schema")

This command will work both in source directory and installation directory.

> Your patch looks good, but I would prefer not to have two almost
> identical routines.  Instead, can we parametrise the listener?
> ie, one 'listen on tcp and udp' function, which for kpassed (as an
> example) provides kpasswdd_tcp_stream_ops and kpasswdd_process as a
> parameter?  (Bonus points for rationalising it down to just
> kpasswd_process). 

Please take a look at the attached patches. They should be applied on
top of patch #1.

Patch #4 merges the 2 add_socket functions using the stream_ops and
process as parameters.

Patch #5 eliminates the stream_ops parameter by constructing it
dynamically and storing the process in its private_data. The
kdc_tcp_accept() will get the process from the private_data.

Is this correct? The quicktest passed. Thanks.

Endi S. Dewata

More information about the samba-technical mailing list