[IPA] Disabling Heimdal service

[Andrew Bartlett]

On Tue, 2009-11-24 at 02:22 -0500, Endi Sukma Dewata wrote:
> Andrew,
> 
> ----- "Andrew Bartlett" <abartlet at samba.org> wrote:
> 
> > > The second one copies some additional setup files into the install dir. 
> 
> > I'm not sure on this.  I'll push the ldap_backend_start.sh template into
> > inline strings in the python code, I think it's too small and silly to
> > bother having in a file.
> 
> Ok, feel free to remove this part from the patch.
> 
> > The copy of the schema is a bit more of a worry to me - where does it
> > end up exactly?
> 
> cp -r ../examples $SETUPDIR/../..
> 
> In this command the $SETUPDIR points to $DESTDIR/share/setup. $DESTDIR
> is the installation directory, e.g. /usr/local/samba. So the command will
> copy the examples into $DESTDIR becoming $DESTDIR/examples.

I don't like that this breaks if setup becomes anything other than
$DESTDIR/share/setup

> The relative location of the setup and examples directories in the 
> installation directory will be the same as that in the source directory.
> See also provisionbackend.py line 569:
> 
> self.samba3_schema = self.setup_path("../../examples/LDAP/samba.schema")
> 
> This command will work both in source directory and installation directory.

I realise that's why you do it, but that it works and produces a
reasonable path seems to be more due to blind luck than anything else.

> > Your patch looks good, but I would prefer not to have two almost
> > identical routines.  Instead, can we parametrise the listener?
> > 
> > ie, one 'listen on tcp and udp' function, which for kpassed (as an
> > example) provides kpasswdd_tcp_stream_ops and kpasswdd_process as a
> > parameter?  (Bonus points for rationalising it down to just
> > kpasswd_process). 
> 
> Please take a look at the attached patches. They should be applied on
> top of patch #1.
> 
> Patch #4 merges the 2 add_socket functions using the stream_ops and
> process as parameters.
> 
> Patch #5 eliminates the stream_ops parameter by constructing it
> dynamically and storing the process in its private_data. The
> kdc_tcp_accept() will get the process from the private_data.
> 
> Is this correct? The quicktest passed. Thanks.

It looks reasonable. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091124/5f739142/attachment.pgp>