[PATCH] s4-drs: Removes stored parentGUID's creation and renaming

tridge at samba.org tridge at samba.org
Thu Nov 19 20:25:08 MST 2009

Hi Fernando,

nice work! I've now pushed all 3 of your patches to master.

I also added a patch to operational.c that removes parentGUID if it is
in the database from an old install and is not requested by the
user. You might like to look at that patch to see the approach I
used. That also allowed us to fix a long standing bug with displaying
ntSecurityDescriptor when we shouldn't.

When you've done some test additions for these changes then please
send them along for me to look at.

btw, if you could, for future patches please push your patches to
your repo.or.cz repository. It is a bit easier to pull them from there
than to use email.

I also suggest you explain things a bit more in your commit
messages. One line commit messages are sometimes OK, but I think in
this case it warranted a little bit more. I added a bit to your commit
messages when I pushed your changes.

Cheers, Tridge

More information about the samba-technical mailing list