[PATCH] s4-drs: Removes stored parentGUID's creation and renaming

Fernando J V da Silva fernandojvsilva at yahoo.com.br
Thu Nov 19 11:35:38 MST 2009

Hi Tridge!

The only comments I have are on formatting.
Sorry (3) for my mistakes about the coding style... =(

Now the only difference is:
-                               attrs, NULL,
+                              attrs, NULL,
In the old code, there was a trailing whitespace, so I removed it.

> Have you thought about adding a test case to
> lib/ldb/tests/python/ldap.py for your patches? I would be happy to
> accept your patches without a test case, but it would be good if you
> could submit a further patch afterwards to add a test case that
> demonstrates what you have fixed.

yes! I'm intended to do it soon! I just didn't have enough time yet to take
a look
at the ldap.py to understand how exactly it works ... but I hope to do it
soon! =)

Best regards,

Fernando J V da Silva
M Sc Computer Science Student
Institute of Computing, State University of Campinas
+55 15 8801-2165
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-drs-Removes-stored-parentGUID-s-creation-and-ren.patch
Type: text/x-patch
Size: 5017 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091119/6e6ed1f5/attachment.bin>

More information about the samba-technical mailing list