packet_* => tstream glue

[Stefan (metze) Metzmacher]

Andrew Bartlett schrieb:
> On Wed, 2009-11-04 at 16:20 +0100, Stefan (metze) Metzmacher wrote:
>> Hi Andrew,
>>
>> here's the wrapper to use the packet_* full_request functions with tstream.
>>
>> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=7123249cbbc8c5b72d1fbe4936cbd2b6cd4ddee9
>>
>> (I haven't compiled it yet...)
> 
> And I've not tried it, but it does look like it could be very useful. 

I have some local changes to it, I hope to get it ready to push within
this week.

> The use of 'send' and 'recv' in the tsocket code is really quite
> confusing.

that's why I don't added tstream_recv_recv and tstream_send_send,
but tstream_readv_recv and tstream_writev_send.

> In this case, it means 'start' and 'conclude' (or 'finish')
> the asynchronous operations, rather than to send() and recv() packets. 
> 
> Would it be at all possible to change those names?  It really bends the
> mind a bit too much.

The caller sends its desire to get a result of a specific task with the
_send function. And gets the result with the _recv function.

For me it's not confusing, but I'm also not a native speaker...

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091105/5f1053f5/attachment.pgp>