Remove use of str_list_make_v3

Andrew Bartlett abartlet at
Fri May 15 01:50:11 GMT 2009

On Thu, 2009-05-14 at 23:06 +0200, Volker Lendecke wrote:
> On Fri, May 15, 2009 at 03:24:32AM +1000, Andrew Bartlett wrote:
> > Here I attach a patch to use str_list_make_shell(), which *should* be
> > equivilant to str_list_make_v3(), with the exception that like
> > str_list_make(), it returns an empty (not NULL) list for a "" or NULL
> > argument.  I've adjusted password.c and map_username.c to cope with
> > this.  (Need to check and understand the loadparam behaviour).
> Looking at str_list_make_shell() it uses strcspn() to figure
> out the separators, whereas str_list_make_v3 uses
> strchr_m(). Are they equivalent?

I think that's what the comment about 'must be below 2f' is about
guaranteeing.  (in the same way we use that property for faster handling
of /).   (I'm actually not sure why this is 2f, not 7f, but perhaps I
don't really understand multibyte).

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team 
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list