Remove use of str_list_make_v3
Volker.Lendecke at SerNet.DE
Fri May 15 06:29:50 GMT 2009
On Fri, May 15, 2009 at 11:50:11AM +1000, Andrew Bartlett wrote:
> On Thu, 2009-05-14 at 23:06 +0200, Volker Lendecke wrote:
> > On Fri, May 15, 2009 at 03:24:32AM +1000, Andrew Bartlett wrote:
> > > Here I attach a patch to use str_list_make_shell(), which *should* be
> > > equivilant to str_list_make_v3(), with the exception that like
> > > str_list_make(), it returns an empty (not NULL) list for a "" or NULL
> > > argument. I've adjusted password.c and map_username.c to cope with
> > > this. (Need to check and understand the loadparam behaviour).
> > Looking at str_list_make_shell() it uses strcspn() to figure
> > out the separators, whereas str_list_make_v3 uses
> > strchr_m(). Are they equivalent?
> I think that's what the comment about 'must be below 2f' is about
> guaranteeing. (in the same way we use that property for faster handling
> of /). (I'm actually not sure why this is 2f, not 7f, but perhaps I
> don't really understand multibyte).
I think Jeremy should comment on this, he has done much work
in the Samba 3 charconv code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090515/b1ffdf14/attachment.bin
More information about the samba-technical