[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1463-g512879a

Jeremy Allison jra at samba.org
Fri May 8 16:11:44 GMT 2009


On Fri, May 08, 2009 at 10:08:48AM +0200, Volker Lendecke wrote:
> On Thu, May 07, 2009 at 09:48:33AM -0700, Jeremy Allison wrote:
> > > Your following commit has the same problem.
> > > 
> > > > +	subreq = cli_smb_send(state, ev, cli, SMBsetattrE, additional_flags,
> > > > +			      7, vwv, 0, NULL);
> > > 
> > > In general all non scalar input parameters to a _send() function need to
> > > be arround until the _recv function is called.
> > 
> > Thanks, that wasn't clear from the API. I'll review and fix
> > that code asap.
> 
> There was no time in my little tutorial, but I found this
> general rule to be very helpful:
> 
> All callers of an async function have to make sure that the
> resources an async engine needs are around and not touched
> until after the _recv function is called.

Yes, I've realized that and changed the code to suit. I'll
not make this mistake in future.

Jeremy.


More information about the samba-technical mailing list