[PATCH] Make struct tevent_req opaque 3

simo idra at samba.org
Sun Mar 1 23:25:41 GMT 2009


On Sun, 2009-03-01 at 13:31 +0100, Volker Lendecke wrote:
> On Sat, Feb 28, 2009 at 07:50:45PM -0500, simo wrote:
> > Updated patch.
> > 
> > After some discussion with Volker, we decide to shorten the names of
> > tevent_req_get_private_data() into _tevent_req_callback_data()
> > and
> > tevent_req_get_private_state() into _tevent_req_state()
> 
> Hmmm. Another look revealed that we have an "enum
> tevent_req_state" and now also a macro tevent_req_state.
> Probably it would be better to rename the macro
> tevent_req_state to tevent_req_get_state to avoid confusion,
> and despite the fact it's 4 chars longer :-)

Ok given that private_state is not really a state but data, and we
already have an enum called tevent_req_state we discussed on IRC to use
tevent_req_data and change the variable in tevent_req from
'private_state' to 'data'.
Attached a patch that implements this.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-struct-tevent_req-opaque.patch
Type: text/x-patch
Size: 22202 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090301/2841669e/0001-Make-struct-tevent_req-opaque.bin


More information about the samba-technical mailing list