[PATCH] Make struct tevent_req opaque 3

[Stefan (metze) Metzmacher]

simo schrieb:
> On Sun, 2009-03-01 at 13:31 +0100, Volker Lendecke wrote:
>> On Sat, Feb 28, 2009 at 07:50:45PM -0500, simo wrote:
>>> Updated patch.
>>>
>>> After some discussion with Volker, we decide to shorten the names of
>>> tevent_req_get_private_data() into _tevent_req_callback_data()
>>> and
>>> tevent_req_get_private_state() into _tevent_req_state()
>> Hmmm. Another look revealed that we have an "enum
>> tevent_req_state" and now also a macro tevent_req_state.
>> Probably it would be better to rename the macro
>> tevent_req_state to tevent_req_get_state to avoid confusion,
>> and despite the fact it's 4 chars longer :-)
> 
> Ok given that private_state is not really a state but data, and we
> already have an enum called tevent_req_state we discussed on IRC to use
> tevent_req_data and change the variable in tevent_req from
> 'private_state' to 'data'.
> Attached a patch that implements this.

Looks good to me.

But we need a function to set the private_print function.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090302/98eef632/signature.bin