PATCH: Re: talloc -- Eureka*
tridge at samba.org
tridge at samba.org
Wed Jul 29 23:18:13 MDT 2009
Hi Metze,
> See the top 3 commits here (the others have nothing to do with this
> discussion):
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-talloc-metze-3
The logging patches look good, thanks, although it might be worth
adding a static varargs helper function that wraps the
talloc_asprintf() calls in the future, just for neatness. Either that
or expose it as a varargs as you suggested.
Maybe also make the talloc_abort() calls use the logging function?
The talloc_steal change is also OK as although it is ambiguous, at
least we get a warning.
Thanks!
Cheers, Tridge
PS: I will be away until Tuesday after tonight
More information about the samba-technical
mailing list