PATCH: Re: talloc -- Eureka*
Stefan (metze) Metzmacher
metze at samba.org
Thu Jul 30 00:25:20 MDT 2009
> > See the top 3 commits here (the others have nothing to do with this
> > discussion):
> > http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-talloc-metze-3
> The logging patches look good, thanks, although it might be worth
> adding a static varargs helper function that wraps the
> talloc_asprintf() calls in the future, just for neatness. Either that
> or expose it as a varargs as you suggested.
I'll change that.
> Maybe also make the talloc_abort() calls use the logging function?
> The talloc_steal change is also OK as although it is ambiguous, at
> least we get a warning.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 252 bytes
Desc: OpenPGP digital signature
More information about the samba-technical