PATCH: Re: talloc -- Eureka*

[Stefan (metze) Metzmacher]

Hi Tridge,

>  > See the top 3 commits here (the others have nothing to do with this
>  > discussion):
>  > http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-talloc-metze-3
> 
> The logging patches look good, thanks, although it might be worth
> adding a static varargs helper function that wraps the
> talloc_asprintf() calls in the future, just for neatness. Either that
> or expose it as a varargs as you suggested.

I'll change that.

> Maybe also make the talloc_abort() calls use the logging function?

correct.

> The talloc_steal change is also OK as although it is ambiguous, at
> least we get a warning.

good.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090730/6c3eb582/attachment.pgp>