abartlet at samba.org
Fri Jul 24 04:20:04 MDT 2009
On Fri, 2009-07-24 at 05:30 -0400, Volker Lendecke wrote:
> On Fri, Jul 24, 2009 at 12:42:04PM +1000, Andrew Bartlett wrote:
> > > Comments?
> > It's not really my area, but it seems like a really big improvement.
> > My only question is: does it remove the SMB_VFS_LAYER_TRANSPARENT and
> > SMB_VFS_LAYER_OPAQUE etc? I've never had reason to try and understand
> > what they did, so I don't know if it's a loss.
> Yes, it removes them. The _OPAQUE_ macros were completely
> unused anyway, so it was really unused. The new scheme is
> right what you would expect: vfs_default provides the
> default actions for all the operations, and modules can step
> in, calling the lower level with _NEXT_.
Sounds like an improvement to me. Nice work!
(I still want - when I find a few spare months - to try and glue the
Samba4 posix NTVFS onto Samba3's modules, and anything to make this
subsystem easier to grok is much appreciated).
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the samba-technical