[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-261-g431e63c

Tim Prouty tprouty at samba.org
Mon Jul 13 23:17:51 GMT 2009

On Jul 7, 2009, at 4:11 AM, Volker Lendecke wrote:

> On Mon, Jul 06, 2009 at 05:42:12PM -0500, Tim Prouty wrote:
>> commit e4a85da5708a08f06a50f4f6b95e22d0e148d85e
>> Author: Tim Prouty <tprouty at samba.org>
>> Date:   Tue Jun 30 16:41:48 2009 -0700
>>    s3 onefs: Fix failure in POSIX smbtorture test
>>    The return value of readlink was a bool instead of an int,
>>    which caused the length of the returned value to never be
>>> 1.
> I've been thinking about the lack of compiler checking in
> the VFS for a while now.

I 100% agree that it would be great if we could move away from having  
a non-type checked vfs interface.

> Would it make sense to rewrite the
> VFS so that every module has to fill in the functions into a
> typed struct? I think one of the reasons why the VFS exists
> as it is now was the pain to fill large almost-empty struct.
> With the C99 style initializers that pain has gone now.

Does this give us full type safety for the vfs interface?  Do you have  
an example of what it would look like?

More information about the samba-technical mailing list