patchs for wireshark dissection

Andrew Bartlett abartlet at
Mon Jul 13 00:15:43 MDT 2009

On Mon, 2009-07-13 at 08:10 +0200, Stefan (metze) Metzmacher wrote:
> Matthieu Patou schrieb:
> > On 07/12/2009 08:37 PM, Stefan (metze) Metzmacher wrote:
> >> I need to revert parts of the patches, to prevent a crash
> >> (in the string handling code...)
> >>
> >>;a=commitdiff;h=c9dbf6ad8c7c3320800bf9158b718c6c98a602f5
> >>
> >>
> >>    
> > Metze can you send me the capture that makes a crash ?
> But also just from looking at the code, it seems to be just wrong.
> The length of the array has nothing to do with the max count!
> There is no magic string terminator that we need to autodetect,
> if there're following (zero or uninitialized) bytes then they're
> just padding!

Perhaps I'm missing something, but wasn't this whole area meant to be
overtaken by PIDL generated dissectors?

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team 
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list