patchs for wireshark dissection

[Stefan (metze) Metzmacher]

Matthieu Patou schrieb:
> On 07/12/2009 08:37 PM, Stefan (metze) Metzmacher wrote:
>> I need to revert parts of the patches, to prevent a crash
>> (in the string handling code...)
>>
>> http://gitweb.samba.org/?p=metze/wireshark/wip.git;a=commitdiff;h=c9dbf6ad8c7c3320800bf9158b718c6c98a602f5
>>
>>
>>    
> Metze can you send me the capture that makes a crash ?

http://samba.org/~metze/ads/rpc-netlogon-lsa-string-is-fine-01.pcap

But also just from looking at the code, it seems to be just wrong.
The length of the array has nothing to do with the max count!
There is no magic string terminator that we need to autodetect,
if there're following (zero or uninitialized) bytes then they're
just padding!

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090713/2835a282/signature.bin