Samba 3.0.32 - internal change notify "legacy" mechanism

[Dina Fine]

If you mean for that part:

+	const char **vfs_objects;
+	
+	/*
+	* Exanet (2008), Dina: no need to use tdb notification mechanism
when
+	* notify hash vfs object is defined (Improves samba performance)
+	*/
+	vfs_objects = lp_vfs_objects(SNUM(conn));
+	if (vfs_objects) {
+		int i = 0;
+		while (vfs_objects[i]) {
+			if (strcmp(vfs_objects[i], "notify_hash") == 0)
{
+				return;
+			}
+			i++;
+		}
+	}
+	
Than It can be removed. This is only a small optimization not even to
open the internal notify tdb file if we use vfs notify layer, but this
is not must.

But other fixes are important and contain a fix to segmentation
violation and also trigger change notify reply for general notifications
on the directory. And must be applied to make the vfs notify work.

Dina

-----Original Message-----
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE] 
Sent: Monday, January 19, 2009 6:44 PM
To: Dina Fine
Cc: samba-technical at lists.samba.org; Evgeny Popovich
Subject: Re: Samba 3.0.32 - internal change notify "legacy" mechanism

On Mon, Jan 19, 2009 at 06:33:40PM +0200, Dina Fine wrote:
> When I posted the new vfs layer I also posted the attached fix patch.
> I resend it now.

Ok, I disregarded this because it contains a hack naming the vfs_hash
module explicitly. Sorry, but that won't go in this way.

There's no way to make this work just from the module?

Volker