[PATCH] Bug in get_dc_name_via_netlogon() in winbindd_cm.c
jra at samba.org
Wed Jan 14 19:42:18 GMT 2009
On Wed, Jan 14, 2009 at 07:20:16PM +0800, boyang wrote:
> Hi, everybody:
> We can rely in the werr status return from
> rpccli_netr_DsRGetDCName(). please have a look at
> rpccli_netr_DsRGetDCName(), if it fails, status is set. But *info is not
> set and werr is not set too. we can reference to null pointer *info
> after the call rpccli_netr_DsRGetDCName(). This only happens when
> rpccli_netr_DsRGetDCName() fails, and werr is originally 0, in which
> case info = NULL; :-)
> patch for master in the attachment, please review it.
Yep, completely correct - thanks !
More information about the samba-technical