[PATCH] make libsmbclient work with DFS (Was: [RFC] To make libsmbclient work for DFS shares for samba3)

[boyang]

Derrell Lipman wrote:
>
> Ok, I'm much happier with this patch. :-)  I have one change I think we
> should make, for consistency, and a naming change request.
>
> 1. The function smbc_set_credentials_wrapper() takes an SMBCCTX * as a
> parameter. The convention in the library is that functions that take a
> SMBCCTX * parameter have it as the first parameter, so please move it from
> the end of the parameter list to the beginning.
>
> 2. If smbc_set_credentials_wrapper() really should be an exposed function in
> the the interface (and it looks like it probably should be), we can probably
> come up with a better name for it. How about either
> smbc_set_credentials_auto() or smbc_set_credentials_with_fallback() ?
>
> If you'd like to make these couple of changes and then submit a patch
> generated with git-format-patch (so you are attributed), I'll commit this
> for you.
>
>
>   
Hi, Derrell:
     I have improved the patch as you suggested. :-) At present, I think
we can site comfortably with the patch. Once other applications rely on
libsmbclient aware of calling smbc_set_credntials() or
smbc_set_credentials_with_fallback() and call it in the authentication
callback function, we can remove smbc_set_credentials_with_fallback()
from SMBC_parse_path() and SMBC_server(), I think.
    I have backported it to v3-[023], please review them. Thanks!

BoYang

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-libsmbclient-dfs-master.diff
Type: text/x-patch
Size: 7725 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090220/40ca0aa3/v2-libsmbclient-dfs-master.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-libsmbclient-dfs-v3-0-test.diff
Type: text/x-patch
Size: 8727 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090220/40ca0aa3/v2-libsmbclient-dfs-v3-0-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-libsmbclient-dfs-v3-2-test.diff
Type: text/x-patch
Size: 9609 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090220/40ca0aa3/v2-libsmbclient-dfs-v3-2-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-libsmbclient-dfs-v3-3-test.diff
Type: text/x-patch
Size: 7739 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090220/40ca0aa3/v2-libsmbclient-dfs-v3-3-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090220/40ca0aa3/boyang.vcf