[PATCH][SAMBA4] 3 patches to get samba4 to build on OpenSolaris
torgeir.lerkerod at gmail.com
Mon Feb 9 15:53:42 MST 2009
> > From how I read it, it just checks for options that happen to be for
> > the IRIX CC - and that it will not add any CFLAGS that don't exist.
> > Does this particular test fail on OpenSolaris for some reason?
> Becase the cc gives something else back. Check SunX on the build farm to
> the same thing.
> sunX doesn't build with --enable-developer, so doesn't hit this problem.
> What does this option do exactly that breaks stuff on OpenSolaris? Are
> the characters in -fullwarn interpreted as individual options? What
It's interperted as an invalid option.
> > > > > 0002-Fix-include.patch:
> > > > > This should ideally go into heimdal upstream, as the code is
> > > > > imported from there.
> > > > Well it wouldn't have been a problem if samba 4's heimdal version
> > > > from aug 2008. There are other fixes like this in there done by
> metze. So
> > > > this needs to go in to build on Solaris until somebody do an upgrade
> > > > heimdal... Of'course you can ignor Solaris as a platform, but if
> > > I'm quite sure we've imported changes from Heimdal since august, and
> > > diff with Heimdal is quite small these days.
> > The date was 28 of aug 2008. You can find the tree that went in her :
> > .
> > And as a reference there are numberous commits by metze fixing things
> > this in source4/heimdal from about 2 weeks back to get samba 4 to build
> > other systems....
> The last import was from 27 October,
> 2b29b7186459d945ec448694164bfe4239b30d72 and
> I wasn't aware we still had this many changes against Heimdal, I'll put
> it in.
> Unfortunately the patch I already committed broke some other hosts, so I
> had to revert it. Does cpp on Solaris assume that all input files are C
> files, or is there some option to specify the file type?
Hmm... I swear I tested it... Sorry about that. I can only check with the
compiler I use, which is the november edition of Sun Studio. Sun cc doesn't
need a flag as it defaults to -Xa which is Sun version of "Assume ANSI C
complince", which also by default enables -xc99.
More information about the samba-technical