[PATCH][SAMBA4] 3 patches to get samba4 to build on OpenSolaris 08.11

[Jelmer Vernooij]

On Mon, 2009-02-09 at 22:58 +0100, Torgeir Lerkerød wrote:
> 2009/2/9 Jelmer Vernooij <jelmer at samba.org>
> > On Mon, 2009-02-09 at 22:28 +0100, Torgeir Lerkerød wrote:
> > > 2009/2/9 Jelmer Vernooij <jelmer at samba.org>
> > > > On Mon, 2009-02-09 at 21:30 +0100, Torgeir Lerkerød wrote:
> > > > > Attached patches makes Samba4 build on OpenSolaris. OpenSolaris
> > passes
> > > > the
> > > > > testsuite with 14 errors, many seems related to the same problem.
> > I'll
> > > > fix
> > > > > that when I figure out whats wrong ;-) (BTW, there is something wrong
> > > > with
> > > > > NSS-Wrapper also had to add the wrapped group to /etc/group to get
> > > > > provisioning working.)
> > > > Thanks for working on fixing this.
> > > >
> > > > 0003-Fix-errornos-expectation-that-all-non-gcc-compilers.patch:
> > > >  This is already using the AX_CFLAGS_IRIX_OPTION() flag, which should
> > > >  do the right thing; I think this may need to be fixed to not do
> > anything
> > > > on Solaris instead.
> > > >
> > >
> > > Have you looked at the code in AX_CFLAGS_IRIX_OPTION. It expects the
> > caller
> > > to know that you have an IRIX cc. So you can of'course rework the howl
> > > AX_CFLAGS_IRIX_OPTION, but a case check is much easier ;-) I am not going
> > to
> > > rework a howl file when a case switch is enough :-D
> > From how I read it, it just checks for options that happen to be for
> > the IRIX CC - and that it will not add any CFLAGS that don't exist.
> > Does this particular test fail on OpenSolaris for some reason?
> Becase the cc gives something else back. Check SunX on the build farm to see
> the same thing.
sunX doesn't build with --enable-developer, so doesn't hit this problem.
What does this option do exactly that breaks stuff on OpenSolaris? Are
the characters in -fullwarn interpreted as individual options? What
breaks?

> > > > 0002-Fix-include.patch:
> > > >  This should ideally go into heimdal upstream, as the code is
> > > >  imported from there.
> > > Well it wouldn't have been a problem if samba 4's heimdal version wasn't
> > > from aug 2008. There are other fixes like this in there done by metze. So
> > > this needs to go in to build on Solaris until somebody do an upgrade of
> > > heimdal... Of'course you can ignor Solaris as a platform, but if not....
> > I'm quite sure we've imported changes from Heimdal since august, and the
> > diff with Heimdal is quite small these days.
> The date was 28 of aug 2008. You can find the tree that went in her :
> http://gitweb.samba.org/?p=metze/heimdal/wip.git;a=shortlog;h=refs/heads/lorikeet-heimdal
> .
> And as a reference there are numberous commits by metze fixing things like
> this in source4/heimdal from about 2 weeks back to get samba 4 to build on
> other systems....
The last import was from 27 October,
2b29b7186459d945ec448694164bfe4239b30d72 and
http://git.samba.org/?p=metze/heimdal/wip.git;a=shortlog;h=refs/heads/lorikeet-heimdal-200810271034

I wasn't aware we still had this many changes against Heimdal, I'll put
it in.

Unfortunately the patch I already committed broke some other hosts, so I
had to revert it. Does cpp on Solaris assume that all input files are C
files, or is there some option to specify the file type?

Cheers,

Jelmer


-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090209/f8ed7ec3/attachment.bin