[PATCHS]: parsing get_dfs_referral messages

[Stefan (metze) Metzmacher]

Matthieu Patou schrieb:
> Hello,
> 
> Please find attach a bunch of patch for parsing get_dfs_referral message.
> 
> * 0001-pidl-Introduce-new-dirrective-relative_short.patch, this patch
> introduce the relative_short directive which is the same as the relative
> on but with an offset stored in 2 bytes. It's needed because DFS_REFERAL
> messages have such kind of offset (
> http://msdn.microsoft.com/en-us/library/cc227017%28PROT.10%29.aspx)

I'll take this splited into a librpc/ndr and a pidl/ patch.

> * 0002-pidl-create-trans.idl-IDL-for-TRANSACTIONS2-extensio.patch, this
> is the IDL for the TRANSACATIONS2 extension which support the call
> get_dfs_referral

I think we should have a dfsblobs.idl similar to drsblobs.idl
instead of having a trans.idl.

Types like TRANS_FLAGS_REFERRAL are confusing, it has nothing directly
todo with (smb_)trans. The prefix should be DFS_ or something similar.

For SMB2 this blobs are transferred via Ioctl calls.


> * 0003-torture-torture-tests-for-get_dfs_referral-of-trans..patch, a
> small torture test to check that we are able to pull from a known
> get_dfs_referral message and also that we are able to push the result to
> get the identical blob

You should add the test under torture/ndr/ where similar tests already
exist instead of creating a complete new subsystem.

> * 0004-idl-add-generated-code.patch

As source3 doesn't use this (yet), we should not add generated files.
Instead update .gitignore.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091212/187bb16a/attachment.pgp>