[PATCHS]: parsing get_dfs_referral messages

[Matthieu Patou]

Hello stephan,

Find attached updates patches due to your comments:
*0001-pidl-Introduce-new-directive-relative_short.patch
*0002-ndr-add-supporting-C-functions-for-directive-relativ.patch
Split of the pidl changes

*0003-idl-introduce-new-file-dfsblobs.idl.patch
Renaming of the trans.idl to have something like drsblobs.idl. The 
prefix has been changed also

*0004-torture-add-new-tests-for-dfsblobs.patch
Torture tests integrated into ndr tests

*0005-add-ignore-for-autogenrated-files-as-they-are-not-us.patch
Ignore for the autogenerated files.

It's also available at

http://repo.or.cz/w/Samba/ekacnet.git/shortlog/refs/heads/msdfs-review

Let me know.

Matthieu.

On 12/12/2009 12:09, Stefan (metze) Metzmacher wrote:
> Matthieu Patou schrieb:
>    
>> Hello,
>>
>> Please find attach a bunch of patch for parsing get_dfs_referral message.
>>
>> * 0001-pidl-Introduce-new-dirrective-relative_short.patch, this patch
>> introduce the relative_short directive which is the same as the relative
>> on but with an offset stored in 2 bytes. It's needed because DFS_REFERAL
>> messages have such kind of offset (
>> http://msdn.microsoft.com/en-us/library/cc227017%28PROT.10%29.aspx)
>>      
> I'll take this splited into a librpc/ndr and a pidl/ patch.
>
>    
>> * 0002-pidl-create-trans.idl-IDL-for-TRANSACTIONS2-extensio.patch, this
>> is the IDL for the TRANSACATIONS2 extension which support the call
>> get_dfs_referral
>>      
> I think we should have a dfsblobs.idl similar to drsblobs.idl
> instead of having a trans.idl.
>
> Types like TRANS_FLAGS_REFERRAL are confusing, it has nothing directly
> todo with (smb_)trans. The prefix should be DFS_ or something similar.
>
> For SMB2 this blobs are transferred via Ioctl calls.
>
>
>    
>> * 0003-torture-torture-tests-for-get_dfs_referral-of-trans..patch, a
>> small torture test to check that we are able to pull from a known
>> get_dfs_referral message and also that we are able to push the result to
>> get the identical blob
>>      
> You should add the test under torture/ndr/ where similar tests already
> exist instead of creating a complete new subsystem.
>
>    
>> * 0004-idl-add-generated-code.patch
>>      
> As source3 doesn't use this (yet), we should not add generated files.
> Instead update .gitignore.
>
> metze
>
>