Commit: 0920e0b63b806c8ed4839271048dd4924ed02b2b

[Kamen Mazdrashki]

Hi Tridge,


On Sat, Nov 28, 2009 at 07:32,  <tridge at samba.org> wrote:
> 
> no, please don't use an environment variable for this sort of thing.
> 
> If you want to have a way to override the location of this test ldb,
> then use lp_parm_string() and then pass the location using the
> --option command line option. To see some examples of this, try:
> 
>   git grep lp_parm_string source4/torture/
> 
> for example, you could have:
> 
>   ldb_url = lp_parm_string(tctx->lp_ctx, NULL, "drstest", "ldb_url");
> 
> and then set it with:
> 
>   --option drstest:ldb_url=foo.ldb
> 

Could you please review the attached patches?
First one reverts your commit and second uses lp_param_string()
instead of getenv("LDB_URL") to find out what temporary ldb_url 
should be used.

CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-s4-drstest-don-t-use-getenv-LDB_URL-in-t.patch
Type: application/octet-stream
Size: 2076 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091204/aef63557/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-drstest-Use-lp_param_string-instead-of-getenv.patch
Type: application/octet-stream
Size: 1493 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091204/aef63557/attachment-0001.obj>