Stefan (metze) Metzmacher
metze at samba.org
Wed Aug 12 11:46:42 MDT 2009
Stefan (metze) Metzmacher schrieb:
> Hi Tridge,
>> > See the top 3 commits here (the others have nothing to do with this
>> > discussion):
>> > http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-talloc-metze-3
>> The logging patches look good, thanks, although it might be worth
>> adding a static varargs helper function that wraps the
>> talloc_asprintf() calls in the future, just for neatness. Either that
>> or expose it as a varargs as you suggested.
> I'll change that.
>> Maybe also make the talloc_abort() calls use the logging function?
>> The talloc_steal change is also OK as although it is ambiguous, at
>> least we get a warning.
Here's my current branch I'm proposing for master:
(I'll not push it until I've acks from all who participate in the
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 252 bytes
Desc: OpenPGP digital signature
More information about the samba-technical