[PATCH] Have the smbcli_session record the OS and Native LANMAN of the remote server

Sam Liddicott sam at liddicott.com
Wed Apr 29 17:45:23 GMT 2009



-----Original Message-----
From: Volker Lendecke <Volker.Lendecke at SerNet.DE>
>
>There was a time in Samba development where our
>recommendations told us this is good. At some point this
>changed again to the 
>
>ctrl[i] = talloc(ctrl, struct ldb_control);
>if (ctrl[i] == NULL) {
>}
>
>style for better debuggability. But obviously we did not
>change all the code from in between.

This reason goes a long way to ease the pain of writing such unreadably long winded code.

I'll see if I can bear to redo that patch... although I might have to post it under a false name :-)

Thanks

Sam


More information about the samba-technical mailing list