[SCM] Samba Shared Repository - branch master updated - 62791bbd030f7db272ca68260a4f7586de6576d0

Gerald (Jerry) Carter jerry at samba.org
Tue Sep 16 17:50:33 GMT 2008

Hash: SHA1

Volker Lendecke wrote:
> Hi, Jerry!
>>     idmap_ad: Fix a segfault when calling nss_get_info() with a NULL ads structure.
> Is this the right level to fix the bug? When looking at the
> call chain leading here I get the impression that the main
> caller is query_user in winbindd_ads.c. Shouldn't this
> caller make sure that the ads_struct is non-NULL?
> Am I missing anything?

It's the correct place IMO.  If you look at query_user,
whe the netsamlog_cache entry is inplace, we call
nss_get_info_cached() since we've already cached info
hopefully.  But if we have not, the nss_get_info() is passed
a NULL ADS pointer.   Note that the *only* reason I ever included
the ADS_STRUCT* in the API signature here was to allow
winbindd_ads.c to pass in previous search results (if it had them)
as an optimization.

Does that make sense?

cheers, jerry
- --
Samba                                    ------- http://www.samba.org
Likewise Software          ---------  http://www.likewisesoftware.com
"What man is a man who does not make the world better?"      --Balian
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the samba-technical mailing list