[SCM] Samba Shared Repository - branch master updated - 1d3dcd1e420104c23769b691d0b8b7958d5c58a7

Herb Lewis hlewis at panasas.com
Wed Oct 29 00:13:16 GMT 2008


FYI this function causes some of our utility programs to fail.

For instance, if you start winbindd with -s <non-default config file>
then try to run

smbcontrol winbindd debuglevel

you get errors that it cannot find the pid for winbindd

Michael Adam wrote:
> The branch, master has been updated
>        via  1d3dcd1e420104c23769b691d0b8b7958d5c58a7 (commit)
>       from  268caef85e831208aeebcd4d2d45baa5ed5025cb (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 1d3dcd1e420104c23769b691d0b8b7958d5c58a7
> Author: Michael Adam <obnox at samba.org>
> Date:   Thu Oct 23 00:48:34 2008 +0200
> 
>     [s3]pidfile_create: use check is_default_dyn_CONFIGFILE() since we have it.
>     
>     Michael
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source3/lib/pidfile.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source3/lib/pidfile.c b/source3/lib/pidfile.c
> index f49f8af..3495dae 100644
> --- a/source3/lib/pidfile.c
> +++ b/source3/lib/pidfile.c
> @@ -93,7 +93,7 @@ void pidfile_create(const char *program_name)
>  
>  	/* Add a suffix to the program name if this is a process with a
>  	 * none default configuration file name. */
> -	if (strcmp( CONFIGFILE, get_dyn_CONFIGFILE()) == 0) {
> +	if (is_default_dyn_CONFIGFILE()) {
>  		name = SMB_STRDUP(program_name);
>  	} else {
>  		short_configfile = strrchr( get_dyn_CONFIGFILE(), '/');
> 
> 


More information about the samba-technical mailing list