[RFC] i18n/l10n pam_winbind for samba 3.x

Jeremy Allison jra at samba.org
Tue Oct 28 15:41:15 GMT 2008

On Tue, Oct 28, 2008 at 12:28:45PM +0800, boyang wrote:
> >   
> I am not sure whether d_printf() is suitable for pam_winbind, because
> the library doesn't know where it will print to.:-) Am I right? So I am
> working with gettext. But there is still a problem with the

You misunderstood me. I meant "anything already using d_printf
is a candidate for using gettext" :-). gettext is obviously
the way to go.

> initialization of ntstatus_errors[], it is statically initialized, we
> cannot use gettext in it.
> one way is to use gettext in _get_ntstatus_error_string(), which causes
> it return i18n'ed string. But it puts burden on message string merging
> if error codes are added.
> another way is to add an initialization function in pam_winbind library,
> which makes the code less concise. :-)
> It seems that we have to give up one thing for another, easy message
> merging VS. clean code. Which one is preferred?

Hmmmm. I think we need to use gettext in _get_ntstatus_error_string,
it will be cleaner in the long run.


More information about the samba-technical mailing list