[SCM] Samba Shared Repository - branch master updated - 16bbfc22629ea9e9aebc6164cae28a6b031cd9e0

Andrew Bartlett abartlet at samba.org
Wed Oct 15 00:48:23 GMT 2008


On Tue, 2008-10-14 at 19:34 -0500, Tim Prouty wrote:
> The branch, master has been updated
>        via  16bbfc22629ea9e9aebc6164cae28a6b031cd9e0 (commit)
>       from  98a6b91da57ba71a0fe971cb24b1647d5f0062e8 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 16bbfc22629ea9e9aebc6164cae28a6b031cd9e0
> Author: Tim Prouty <tim.prouty at isilon.com>
> Date:   Mon Oct 6 18:55:21 2008 -0700
> 
>     Fixed "argument differ in signedness" warning on linux

> -static NTSTATUS validate_smb_crypto(struct cli_state *cli, uint8_t *pdu)
> +static NTSTATUS validate_smb_crypto(struct cli_state *cli, char *pdu)
>  {
>  	NTSTATUS status;
>  
> @@ -710,7 +710,7 @@ static NTSTATUS validate_smb_crypto(struct cli_state *cli, uint8_t *pdu)
>  	if (cli_encryption_on(cli) && CVAL(pdu, 0) == 0) {
>  		uint16_t enc_ctx_num;
>  
> -		status = get_enc_ctx_num(pdu, &enc_ctx_num);
> +		status = get_enc_ctx_num((uint8_t *)pdu, &enc_ctx_num);

This does not look right - binary data buffers should always be uint8_t
*, and never char * (which in Samba normally indicates an ascii-like
string).  Rather than adding casts, perhaps find the caller where the
wrong sign starts?

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081015/185aa2af/attachment.bin


More information about the samba-technical mailing list