348be5f1e44c0 (Share data_blob implementation) breaks Samba3

[Andrew Bartlett]

On Sun, 2008-10-12 at 14:41 -0700, Jeremy Allison wrote:
> On Mon, Oct 13, 2008 at 08:17:15AM +1100, Andrew Bartlett wrote:
> > On Sun, 2008-10-12 at 21:40 +0200, Volker Lendecke wrote:
> > > Hi, Jelmer!
> > > 
> > > $SUBJECT says it all. data_blob_string_const() in Samba3
> > > included the terminating NUL, while the new implementation
> > > does not. I am not sure what in Samba4 I break if I just add
> > > the +1. I found it because I get valgrind errors in smbd
> > > now.
> > > 
> > > What do we do about these subtle differences?
> > 
> > Ouch.  It is important not to include the terminating NULL, as this is
> > the convention of ldb (that strings, while normally NULL terminated, are
> > strictly length-limited blobs), which also uses data blobs.
> 
> In that case Jelmer needs to revert his commit and we need
> to use a separately named data type here. We can't have
> these collisions, as they'll end up breaking both branches.

Or we can find out which bits rely on the different behaviours.  Why
does Samba3's smbd rely on a length-limited string being also NULL
terminated?

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081013/ced6ee09/attachment.bin