348be5f1e44c0 (Share data_blob implementation) breaks Samba3
jra at samba.org
Sun Oct 12 21:41:45 GMT 2008
On Mon, Oct 13, 2008 at 08:17:15AM +1100, Andrew Bartlett wrote:
> On Sun, 2008-10-12 at 21:40 +0200, Volker Lendecke wrote:
> > Hi, Jelmer!
> > $SUBJECT says it all. data_blob_string_const() in Samba3
> > included the terminating NUL, while the new implementation
> > does not. I am not sure what in Samba4 I break if I just add
> > the +1. I found it because I get valgrind errors in smbd
> > now.
> > What do we do about these subtle differences?
> Ouch. It is important not to include the terminating NULL, as this is
> the convention of ldb (that strings, while normally NULL terminated, are
> strictly length-limited blobs), which also uses data blobs.
In that case Jelmer needs to revert his commit and we need
to use a separately named data type here. We can't have
these collisions, as they'll end up breaking both branches.
More information about the samba-technical