[linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset

Steve French smfrench at gmail.com
Sun Oct 12 16:57:47 GMT 2008

On Sun, Oct 12, 2008 at 11:53 AM, Steve French <smfrench at gmail.com> wrote:
> On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton at redhat.com> wrote:
>> On Sun, 12 Oct 2008 08:40:39 -0500
>> "Steve French" <smfrench at gmail.com> wrote:
>> Actually, I like Adrian/Rafael's fix better. I think we should avoid
>> cluttering up the code with #ifdef's where possible. key_put() already
>> is a no-op when CONFIG_KEYS is disabled. We might as well do the same
>> thing with key_revoke().
> I don't think it matters much - but we probably shouldn't be
> overriding global functions.

To clarify, I like fixing it in keys.h better than overriding it in
cifs, but in the meantime we need an ifdef in cifs until keys.h



More information about the samba-technical mailing list