[linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset

Steve French smfrench at gmail.com
Sun Oct 12 16:53:19 GMT 2008

On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton at redhat.com> wrote:
> On Sun, 12 Oct 2008 08:40:39 -0500
> "Steve French" <smfrench at gmail.com> wrote:
>> Rafael and Guo-Fu,
>> The following change to address the compile error that you noted is
>> slightly different than what you suggested but should fix what you
>> found.
> Actually, I like Adrian/Rafael's fix better. I think we should avoid
> cluttering up the code with #ifdef's where possible. key_put() already
> is a no-op when CONFIG_KEYS is disabled. We might as well do the same
> thing with key_revoke().
I don't think it matters much - but we probably shouldn't be
overriding global functions.



More information about the samba-technical mailing list