[PATCH 2/N] cleanup return values of convert_string, push_utf8, and friends

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed May 21 05:40:51 GMT 2008

On Tue, May 20, 2008 at 05:05:35PM -0700, Tim Prouty wrote:
> On May 20, 2008, at 2:19 PM, Volker Lendecke wrote:
> >I had to add the proto changes manually, and you forgot one
> >call in vfs_catia.c. I just added that.
> Yeah, I saw the proto mail Michael sent out.  While there may be some  
> pain in the short term, I think moving away from proto.h is a good  
> idea.  I'm surprised I missed that pull_ucs2_talloc in vfs_catia.  Is  
> vfs_catia not compiled by default?

No, not compiled by default.

> >Thanks for that cleanup, keep them coming!
> No problem.  Thanks for reviewing a 2,000 line diff.  I'll try to make  
> future patches a bit more manageable :).

It was quite mechanical, and I'm not 100% certain I would
have caught a case when you would have exchanged a parameter
in one of those function calls :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080521/be39ef4a/attachment.bin

More information about the samba-technical mailing list