[PATCH 2/N] cleanup return values of convert_string, push_utf8, and friends

Tim Prouty tim.prouty at isilon.com
Wed May 21 00:05:35 GMT 2008

On May 20, 2008, at 2:19 PM, Volker Lendecke wrote:

> I had to add the proto changes manually, and you forgot one
> call in vfs_catia.c. I just added that.

Yeah, I saw the proto mail Michael sent out.  While there may be some  
pain in the short term, I think moving away from proto.h is a good  
idea.  I'm surprised I missed that pull_ucs2_talloc in vfs_catia.  Is  
vfs_catia not compiled by default?

> Thanks for that cleanup, keep them coming!

No problem.  Thanks for reviewing a 2,000 line diff.  I'll try to make  
future patches a bit more manageable :).


More information about the samba-technical mailing list