[PATCH] [Re-Revised]: OneFS build issues for Samba 3.2

Timur I. Bakeyev timur at FreeBSD.org
Wed Jul 9 09:06:43 GMT 2008

Hi, Zach!

On Wed, Jul 9, 2008 at 9:19 AM, Zachary Loafman
<zachary.loafman at isilon.com> wrote:
> In addition, I rebased all the previous patches:
> 0001 - Check for f_frsize when you find statvfs. Yes, this is an oddity
> of our platform.

Actually, are you sure, that stavfs() should be used? If you platform
based on FreeBSD - I'd rather use stafs().

> 0003 - Fixes various general warnings. The only potentially be
> objectionable one here is the iconv() change. If you wish, I can add
> configure test for whether the second argument of iconv() is properly
> constified (on BSD it is, but presumably whoever added the (char **)
> cast has a platform where it is not), but given that we wrap it
> immediately and then don't use the native iconv elsewhere, it seems fine
> to (void *) it.

This seems duplicate the work, been done in the FreeBSD samba3 port,
dunno, why this still wasn't comited into the main tree :(

> 0004 - Fixes some warnings that I'm pretty sure are specific to FreeBSD.
> Our 6.1 based system has reboot defined in unistd, so any variable using
> the name tickles -Wshadow, similarly for tcp_seq.

This ones would be nice to get commited too...

I'll try to check your patches together with other FreeBSD patches to
see, how do they fit the general distribution.

Thank you for sharing the code!

With regards,

More information about the samba-technical mailing list