[PATCH] [Re-Revised]: OneFS build issues for Samba 3.2

[Zachary Loafman]

0005 - After rebasing, I found an issue that may need to get addressed
for many platforms: v3-3-test uses a sed with a complex regexp to get
from, say, "libtdb.so.1" to "libtdb.sym". Unfortunately, sed on our
platform uses the minimalist POSIX set and doesn't understand \?. It
instead requires the use a bound, \{0,1\} (which *is* defined in the
minimalist set, because you can use bounds to implement \?, \+, \* and
more). I wouldn't be surprised if Solaris, HPUX or AIX had a similar
minimalist sed by default.

In addition, I rebased all the previous patches:

0001 - Check for f_frsize when you find statvfs. Yes, this is an oddity
of our platform.

0002 - Adds an --enable-picky-developer to add -Werror for those of us
that really, really don't like warnings. (BTW, thank you so very much
for getting 3.2 to compile as clean as it does, it was a real pain
getting 3.0 to compile with -Werror.) If you don't like this change,
I'll happily just make sure it's a CFLAG for us, but I'd like to
encourage people to be pickier.

0003 - Fixes various general warnings. The only potentially be
objectionable one here is the iconv() change. If you wish, I can add
configure test for whether the second argument of iconv() is properly
constified (on BSD it is, but presumably whoever added the (char **)
cast has a platform where it is not), but given that we wrap it
immediately and then don't use the native iconv elsewhere, it seems fine
to (void *) it.

0004 - Fixes some warnings that I'm pretty sure are specific to FreeBSD.
Our 6.1 based system has reboot defined in unistd, so any variable using
the name tickles -Wshadow, similarly for tcp_seq.

I just fetched to double check, these should all apply cleanly now.

...Zach

> -----Original Message-----
> From:
samba-technical-bounces+zachary.loafman=isilon.com at lists.samba.org
> [mailto:samba-technical-
> bounces+zachary.loafman=isilon.com at lists.samba.org] On Behalf Of
Zachary
> Loafman
> Sent: Tuesday, July 08, 2008 4:40 PM
> To: samba-technical at lists.samba.org
> Subject: RE: [PATCH] Revised: OneFS build issues for Samba 3.2
> 
> Sorry, Tim noticed an issue in my patches: I was still based on
> v3-2-test. I just moved over to v3.3 and found s'more build issues on
> our platform, will try to have a better patch set out later tonight.
> 
> > -----Original Message-----
> > From:
> samba-technical-bounces+zachary.loafman=isilon.com at lists.samba.org
> > [mailto:samba-technical-
> > bounces+zachary.loafman=isilon.com at lists.samba.org] On Behalf Of
> Zachary
> > Loafman
> > Sent: Thursday, July 03, 2008 11:47 PM
> > To: samba-technical at lists.samba.org
> > Subject: [PATCH] Revised: OneFS build issues for Samba 3.2
> >
> > Ignore the ones below. Better patches attached.
> >
> > The first two are configure changes:
> > 0001 - Check for f_frsize when you find statvfs.
> > 0002 - Adds an --enable-picky-developer to add -Werror for those of
> that
> > really, really don't like warnings. (BTW, thank you so very much for
> > getting 3.2 to compile as clean as it does, it was a real pain
getting
> > 3.0 to compile with -Werror.) If you don't like this change, I'll
> > happily just make sure it's a CFLAG for us, but I'd like to
encourage
> > people to be pickier.
> >
> > The next two couple be merged or stays separate:
> > 0003 - Fixes various general warnings. The only potentially
> > objectionable one here is the iconv() change. If you wish, I can add
a
> > configure test for whether the second argument of iconv() is
properly
> > constified (on BSD it is, but presumably whoever added the (char **)
> > cast has a platform where it is not), but given that we wrap it
> > immediately and then don't use the native iconv elsewhere, it seems
> fine
> > to (void *) it.
> > 0004 - Fixes some warnings that I'm pretty sure are specific to
> FreeBSD.
> > Our 6.1 based system has reboot defined in unistd, so any variable
> using
> > the name tickles -Wshadow, similarly for tcp_seq.
> >
> > After these, I can build without warnings on our platform, yay.
> >
> > ...Zach
> >
> > > -----Original Message-----
> > > From:
> > samba-technical-bounces+zachary.loafman=isilon.com at lists.samba.org
> > > [mailto:samba-technical-
> > > bounces+zachary.loafman=isilon.com at lists.samba.org] On Behalf Of
> > Zachary
> > > Loafman
> > > Sent: Thursday, July 03, 2008 12:29 PM
> > > To: samba-technical at lists.samba.org
> > > Subject: [PATCH] OneFS build issues for Samba 3.2
> > >
> > > Attached are patches for two build issues that occurred when
> > attempting
> > > to build Samba 3.2 on one of our nodes. We're roughly FreeBSD 6.1
> > based,
> > > so I wouldn't be surprised if they appeared there as well.
> > >
> > >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-for-f_frsize-when-using-statvfs.patch
Type: application/octet-stream
Size: 2487 bytes
Desc: 0001-Check-for-f_frsize-when-using-statvfs.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080709/96e6bb97/0001-Check-for-f_frsize-when-using-statvfs-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-enable-picky-developer.patch
Type: application/octet-stream
Size: 2817 bytes
Desc: 0002-Add-enable-picky-developer.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080709/96e6bb97/0002-Add-enable-picky-developer-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-various-build-warnings.patch
Type: application/octet-stream
Size: 5782 bytes
Desc: 0003-Fix-various-build-warnings.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080709/96e6bb97/0003-Fix-various-build-warnings-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Fix-warnings-on-FreeBSD-based-platforms.patch
Type: application/octet-stream
Size: 25427 bytes
Desc: 0004-Fix-warnings-on-FreeBSD-based-platforms.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080709/96e6bb97/0004-Fix-warnings-on-FreeBSD-based-platforms-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Make-DSO_EXPORTS_CMD-regexp-more-POSIX-compliant.patch
Type: application/octet-stream
Size: 1118 bytes
Desc: 0005-Make-DSO_EXPORTS_CMD-regexp-more-POSIX-compliant.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080709/96e6bb97/0005-Make-DSO_EXPORTS_CMD-regexp-more-POSIX-compliant-0001.obj