[SAMBA 4] [PATCH] Fix IBM checker warnings
jelmer at samba.org
Fri Feb 8 13:19:15 GMT 2008
Am Freitag, den 08.02.2008, 07:05 -0600 schrieb Andrew Kroeger:
> Jelmer Vernooij wrote:
> > A lot of the changes you've made seem to change:
> > bool ret = true;
> > ret &= foo();
> > to
> > ret = ret && foo();
> > (where foo() also returns a boolean)
> > There is nothing wrong with the first expression, and imho it is a bug
> > in the IBM checker that it warns about these sort of expressions.
> > Any chance you can resubmit without those particular changes? The other
> > changes in your patch look ok.
> The changes of:
> ret &= foo();
> ret = ret && foo();
> were intentional.
> The number of issues reported by the IBM checker were becoming quite
> high, and over half of those were related to boolean issues my proposed
> patch attempts to correct.
I would rather report this issue as a false positive to the IBM checker
authors, as we've already done in the past.
The other changes in your patch are ok, and I would be glad to merge
them if you can provide a patch that doesn't include the &= changes.
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
More information about the samba-technical