[SAMBA 4] [PATCH] Fix IBM checker warnings

Andrew Kroeger andrew at id10ts.net
Fri Feb 8 13:05:54 GMT 2008

Jelmer Vernooij wrote:
> A lot of the changes you've made seem to change:
> bool ret = true;
> ret &= foo();
> to
> ret = ret && foo();
> (where foo() also returns a boolean)
> There is nothing wrong with the first expression, and imho it is a bug
> in the IBM checker that it warns about these sort of expressions.
> Any chance you can resubmit without those particular changes? The other
> changes in your patch look ok.

The changes of:
		ret &= foo();
		ret = ret && foo();
were intentional.

The number of issues reported by the IBM checker were becoming quite
high, and over half of those were related to boolean issues my proposed
patch attempts to correct.

By decreasing the number of warnings created during any given build,
hopefully others can focus their work on the helping to eliminate the
remaining issues/warnings.

Andrew Kroeger

More information about the samba-technical mailing list