Improving performance of winbindd_list_groups

simo idra at
Fri Apr 25 18:50:23 GMT 2008

On Thu, 2008-04-24 at 17:51 -0700, Steven Danneman wrote:
> > Looks very good to me, thanks!
> > Just a quick comment: In listgroups_recv you're using talloc_asprintf
> to paste the 
> > results together. These strings can get *very* long, so you might want
> to use 
> > talloc_asprintf_append_buffer, which does not use strlen for the
> existing string.
> > Jerry, what do you think about this patch?
> > Volker
> Thanks Volker,
> That's a good suggestion for even better performance.  Attached is an
> updated patch using talloc_asprintf_append_buffer().  I'm wasn't
> positive from the API description that the returned string will be NULL
> terminated, but in all my tests it seems to be.  Is this a correct
> assumption?

Looks good to me too.


Simo Sorce
Samba Team GPL Compliance Officer <simo at>
Senior Software Engineer at Red Hat Inc. <ssorce at>

More information about the samba-technical mailing list