Improving performance of winbindd_list_groups

Gerald (Jerry) Carter jerry at samba.org
Fri Apr 25 13:11:06 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> On Thu, Apr 24, 2008 at 05:51:13PM -0700, Steven Danneman wrote:
>> That's a good suggestion for even better performance.  Attached is an
>> updated patch using talloc_asprintf_append_buffer().  I'm wasn't
>> positive from the API description that the returned string will be NULL
>> terminated, but in all my tests it seems to be.  Is this a correct
>> assumption?
> 
> Yep. Down below it calls vsnprintf somewhere, that
> terminates. I'd check in your patch, but I'd like Jerry to
> take a look and comment first.

Hey VOlker,

As soon as we finish release things today I'll be freed up some.
Am dealing with branching currently.




jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIEdhqIR7qMdg1EfYRAtRiAKC0oGCkDjpT1c2UYXuQTinr6lL33QCgr8g7
3zZ2tpsmLjz3rJ6ryp9xlwo=
=v/CF
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list