[PATCH] 2/2: Associate file locations to newly introduced path variables

[Andrew Bartlett]

On Tue, 2007-10-16 at 18:20 +0200, Christian Perrier wrote:
> Quoting Gerald (Jerry) Carter (jerry at samba.org):
> 
> > > @@ -66,7 +66,7 @@
> > >             winbindd_cache.tdb open.  Open the tdb if a NULL is passed. */
> > >  
> > >  	if (!tdb) {
> > > -		tdb = tdb_open_log(lock_path("winbindd_cache.tdb"), 
> > > +		tdb = tdb_open_log(cache_path("winbindd_cache.tdb"), 
> > >  				   WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE,
> > >  				   TDB_DEFAULT, O_RDWR, 0600);
> > ....
> > > -	cache_fname = lock_path("idmap_cache.tdb");
> > > +	cache_fname = cache_path("idmap_cache.tdb");
> > >  
> > >  	DEBUG(10, ("Opening cache file at %s\n", cache_fname));
> > 
> > 
> > We've had this discussion before and your patch still suffers
> > from the same assumptions.  Tdb files may operate as both
> 
> Sorry for appearing to beat an old horse...
> 
> 
> > cache and persistent state.  For example, the idmap_cache.tdb
> > and winbindd_cache.tdb are required for offline logons.
> 
> The content of /var/cache/foo is not removed between reboots. Here the
> work "discardable" may be confusing, maybe.... Let's rather use "not
> necessarily backed up"

I think the only separation you are likely to get Jerry to agree on is
between those databases marked as 'clear if first' (lifetime of the
process), and those which expect to be persistent (longer than that).

This is a distinction already used by CTDB to determine how a database
needs to be handled on clustered nodes. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071017/26d9d5a6/attachment.bin